Skip to content

Conversation

@charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Jun 11, 2025

What I did

How I did it

How to verify it

Commit message

fix incorrect write-after-write and write-after-read reordering in
DFT pass.

- writes should be fenced by writes
- writes should be fenced by *all* prior reads, not just the most
  recent read

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

discovered during routine work to increase test suite coverage
@charles-cooper charles-cooper force-pushed the fix/venom/bubble-sort branch from abfae1d to 135fe2a Compare June 11, 2025 20:18
@codecov
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.96%. Comparing base (67ea4ee) to head (2fc9b24).
⚠️ Report is 29 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4695      +/-   ##
==========================================
+ Coverage   92.93%   92.96%   +0.02%     
==========================================
  Files         131      131              
  Lines       19062    19067       +5     
  Branches     3316     3319       +3     
==========================================
+ Hits        17716    17725       +9     
+ Misses        904      902       -2     
+ Partials      442      440       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@charles-cooper charles-cooper marked this pull request as ready for review June 17, 2025 09:24
@charles-cooper charles-cooper changed the title fix[venom]: fix incorrect write reordering in DFTPass fix[venom]: fix incorrect write reordering in DFTPass Jun 17, 2025
@charles-cooper charles-cooper enabled auto-merge (squash) June 17, 2025 10:18
@charles-cooper charles-cooper merged commit 37b636c into vyperlang:master Jun 17, 2025
159 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants