-
-
Notifications
You must be signed in to change notification settings - Fork 872
feat[lang]: bubble up create revertdata #4540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat[lang]: bubble up create revertdata #4540
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4540 +/- ##
==========================================
- Coverage 92.37% 92.35% -0.03%
==========================================
Files 123 123
Lines 17538 17543 +5
Branches 2961 2961
==========================================
+ Hits 16200 16201 +1
- Misses 934 938 +4
Partials 404 404 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pcaversaccio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is incomplete IMO as there is no way to handle specifically the revert data as a user. I made a proposal here to use a kwarg: #4147. Open for other suggestions, but similar to return_data, revert_data should be available for the create_ built-ins if requested by the user. I will reopen the issue again.
What I did
failed creates now bubble up revert data. fixes #4147
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture