Skip to content

Conversation

@charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Mar 25, 2025

What I did

failed creates now bubble up revert data. fixes #4147

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.35%. Comparing base (206a119) to head (48e9121).
Report is 95 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4540      +/-   ##
==========================================
- Coverage   92.37%   92.35%   -0.03%     
==========================================
  Files         123      123              
  Lines       17538    17543       +5     
  Branches     2961     2961              
==========================================
+ Hits        16200    16201       +1     
- Misses        934      938       +4     
  Partials      404      404              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@charles-cooper charles-cooper marked this pull request as ready for review March 26, 2025 09:42
@cyberthirst cyberthirst added this to the v0.4.2 milestone Mar 29, 2025
@cyberthirst cyberthirst added the release - must release blocker label Mar 29, 2025
@charles-cooper charles-cooper enabled auto-merge (squash) March 30, 2025 13:17
@charles-cooper charles-cooper merged commit cef84e8 into vyperlang:master Mar 30, 2025
159 checks passed
Copy link
Collaborator

@pcaversaccio pcaversaccio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is incomplete IMO as there is no way to handle specifically the revert data as a user. I made a proposal here to use a kwarg: #4147. Open for other suggestions, but similar to return_data, revert_data should be available for the create_ built-ins if requested by the user. I will reopen the issue again.

@charles-cooper charles-cooper deleted the feat/bubble-create-reverts branch April 14, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release - must release blocker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add revert_on_failure=False kwarg to create builtins

3 participants