Skip to content

Conversation

@harkal
Copy link
Collaborator

@harkal harkal commented Mar 21, 2025

What I did

Added hex parsing support to the venom text format parser

How I did it

How to verify it

Commit message

This commit adds hex parsing support to the venom text format parser

Description for the changelog

@harkal harkal marked this pull request as ready for review March 21, 2025 08:12
@harkal harkal requested a review from charles-cooper March 21, 2025 08:13
Copy link
Member

@charles-cooper charles-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. i will add a test

@charles-cooper
Copy link
Member

it's reasonable to reject odd-length hex literals, right?

@charles-cooper charles-cooper changed the title feat[venom]: parse hex literals in venom text format feat[venom]: parse hex literals in text format Mar 21, 2025
@codecov
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.28%. Comparing base (11f0761) to head (ce17f6a).
Report is 90 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4532   +/-   ##
=======================================
  Coverage   92.28%   92.28%           
=======================================
  Files         123      123           
  Lines       17493    17495    +2     
  Branches     2952     2953    +1     
=======================================
+ Hits        16143    16145    +2     
  Misses        944      944           
  Partials      406      406           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@charles-cooper charles-cooper merged commit 3e8da7a into vyperlang:master Mar 21, 2025
162 checks passed
@charles-cooper charles-cooper deleted the feat/venom/parse_hex_literals branch March 21, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants