Skip to content

Conversation

@charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Feb 28, 2025

What I did

How I did it

How to verify it

Commit message

add `hevm` to the `get_contract` harness. if the `--hevm` flag
is set when running the test suite, the source code argument to
`get_contract()` will additionally be compiled and equivalence-checked
between venom and non-venom bytecode, using `hevm equivalence`.

individual tests can be marked (as is done in this commit) for
inclusion in the hevm CI job, with `pytest.mark.hevm`, and then any
calls to `get_contract` will run the equivalence checker as described
above.

the idea behind this commit is to makes it easy to increase hevm
equivalence coverage in our test suite, simply by manually annotating
individual tests with `pytest.mark.hevm`.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@charles-cooper charles-cooper changed the title feat[test]: add hevm to get_contract harness feat[test]: add hevm to get_contract harness Feb 28, 2025
@codecov
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.16%. Comparing base (fbcf7d2) to head (29b7baf).
Report is 86 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4499   +/-   ##
=======================================
  Coverage   92.16%   92.16%           
=======================================
  Files         122      122           
  Lines       17471    17471           
  Branches     2959     2959           
=======================================
  Hits        16103    16103           
  Misses        957      957           
  Partials      411      411           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@charles-cooper charles-cooper marked this pull request as ready for review March 8, 2025 13:29
@cyberthirst cyberthirst added this to the v0.4.2 milestone Mar 10, 2025
@charles-cooper charles-cooper enabled auto-merge (squash) March 11, 2025 15:37
@charles-cooper charles-cooper merged commit ded6b2c into vyperlang:master Mar 11, 2025
160 checks passed
@charles-cooper charles-cooper deleted the feat/hevm-harness branch March 11, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants