Skip to content

Conversation

@charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Feb 23, 2025

What I did

How I did it

How to verify it

Commit message

minor refactor of decorator parsing, which simplifies the code and
should make it easier to add new builtin decorators in the future

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

minor refactor of decorator parsing, which simplifies the code and
should make it easier to add new builtin decorators in the future
@charles-cooper charles-cooper added this to the v0.4.2 milestone Feb 23, 2025
@codecov
Copy link

codecov bot commented Feb 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.16%. Comparing base (efdfa7f) to head (32f2cb3).
Report is 88 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4490      +/-   ##
==========================================
+ Coverage   92.11%   92.16%   +0.04%     
==========================================
  Files         122      122              
  Lines       17455    17475      +20     
  Branches     2961     2962       +1     
==========================================
+ Hits        16079    16105      +26     
+ Misses        962      958       -4     
+ Partials      414      412       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cyberthirst
Copy link
Collaborator

didn't look into it closely, but can't we use the new machinery in from_InterfaceDef as well?

@charles-cooper
Copy link
Member Author

didn't look into it closely, but can't we use the new machinery in from_InterfaceDef as well?

no, those have a different machinery since functions in interface declarations don't use decorators

@charles-cooper charles-cooper enabled auto-merge (squash) March 11, 2025 13:30
@charles-cooper charles-cooper merged commit eb2efa3 into vyperlang:master Mar 11, 2025
159 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants