perf[venom]: improve OrderedSet operations #4246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roughly 10% improvement in venom section
dict.keys().__iand__ for better performance, roughly 20% improvement for time spent in venom
harkal
approved these changes
Sep 24, 2024
charles-cooper
added a commit
to charles-cooper/vyper
that referenced
this pull request
Oct 5, 2024
improve time spent in venom by 25% dict views support set operations, which allows us to loop, using `&=`. since our intersections are typically not between a large number of OrderedSets, this results in faster execution time. references: - https://docs.python.org/3/library/stdtypes.html#dict-views
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
improve time spent in venom by 25%
How I did it
dict views support set operations, https://docs.python.org/3/library/stdtypes.html#dict-views
How to verify it
check
time vyper --optimize nonevstime vyper --experimental-codegen --optimize nonefor a large-ish vyper contractCommit message
Description for the changelog
Cute Animal Picture