feat: remove Index AST node #3757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| @classmethod | ||
| def get_subscripted_type(self, node: vy_ast.Index) -> None: | ||
| def get_subscripted_type(self, node: vy_ast.VyperNode) -> None: |
Check notice
Code scanning / CodeQL
First parameter of a class method is not named 'cls'
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3757 +/- ##
==========================================
- Coverage 84.78% 84.75% -0.04%
==========================================
Files 92 92
Lines 13141 13128 -13
Branches 2930 2929 -1
==========================================
- Hits 11142 11126 -16
- Misses 1535 1539 +4
+ Partials 464 463 -1 ☔ View full report in Codecov by Sentry. |
charles-cooper
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Deprecate
IndexAST node.How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture