Skip to content

feat: make send() gas stipend configurable #3158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charles-cooper merged 12 commits into from
Dec 8, 2022
Merged

feat: make send() gas stipend configurable #3158

Changes from 2 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f6b6486
make send() gas stipend configurable
emc415 Nov 25, 2022
ffe645a
Merge branch 'vyperlang:master' into feat/send_gas_stipend
emc415 Nov 25, 2022
969b67a
changed default value for gas kwarg from "gas" to 0
emc415 Nov 26, 2022
d1787f9
Merge remote-tracking branch 'origin/master' into feat/send_gas_stipend;
emc415 Nov 29, 2022
882d373
add comment to clarify default gas value
emc415 Nov 30, 2022
e63064f
added test for passing a gas value in send()
emc415 Nov 30, 2022
4ab5ad0
ran linter
emc415 Nov 30, 2022
ec77d49
remove test for gas stipend
emc415 Nov 30, 2022
5ec2c93
updated test for added gas kwarg in send()
emc415 Nov 30, 2022
19c2115
added syntax tests for send() gas stipend
emc415 Dec 1, 2022
fc18409
removed unnecessary test
emc415 Dec 7, 2022
fa71cc9
Merge branch 'vyperlang:master' into feat/send_gas_stipend
emc415 Dec 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions vyper/builtin_functions/functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1264,14 +1264,18 @@ class Send(BuiltinFunction):

_id = "send"
_inputs = [("to", AddressDefinition()), ("value", Uint256Definition())]
_kwargs = {"gas": KwargSettings(Uint256Definition(), "gas")}
_return_type = None

@process_inputs
def build_IR(self, expr, args, kwargs, context):
to, value = args
gas = kwargs["gas"]
context.check_is_not_constant("send ether", expr)
return IRnode.from_list(["assert", ["call", 0, to, value, 0, 0, 0, 0]])

if isinstance(gas, str):
return IRnode.from_list(["assert", ["call", 0, to, value, 0, 0, 0, 0]])
else:
return IRnode.from_list(["assert", ["call", gas, to, value, 0, 0, 0, 0]])

class SelfDestruct(BuiltinFunction):

Expand Down