Skip to content

Conversation

@charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Mar 27, 2022

What I did

How I did it

How to verify it

Commit message

change decimal bounds

change from (-2**127 * 10**10, 2**127-1 * 10**10) to (-2**168, 2**168).
this way we use the entire range of the underlying int, and clamps are
more efficient and easier to reason about since we can use the same
clamps as integers.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@charles-cooper charles-cooper force-pushed the change_decimal_bounds branch from 34d17dc to 37910c4 Compare March 28, 2022 18:53
change from (-2**127 * 10**10, 2**127-1 * 10**10) to (-2**168, 2**168).
this way we use the entire space, and clamps are more efficient and
easier to reason about since we can use the same clamps as integers.
@charles-cooper charles-cooper force-pushed the change_decimal_bounds branch from 37910c4 to c05deae Compare March 28, 2022 19:02
@charles-cooper charles-cooper marked this pull request as ready for review March 28, 2022 19:03
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2022

Codecov Report

Merging #2730 (66fe490) into master (dfbca3e) will decrease coverage by 0.02%.
The diff coverage is 97.46%.

@@            Coverage Diff             @@
##           master    #2730      +/-   ##
==========================================
- Coverage   87.25%   87.23%   -0.03%     
==========================================
  Files          93       93              
  Lines        9896     9872      -24     
  Branches     2470     2465       -5     
==========================================
- Hits         8635     8612      -23     
- Misses        777      779       +2     
+ Partials      484      481       -3     
Impacted Files Coverage Δ
vyper/utils.py 88.23% <89.47%> (+0.39%) ⬆️
vyper/ast/folding.py 91.73% <100.00%> (ø)
vyper/ast/nodes.py 94.13% <100.00%> (ø)
vyper/builtin_functions/convert.py 87.23% <100.00%> (+0.39%) ⬆️
vyper/codegen/core.py 84.18% <100.00%> (+0.11%) ⬆️
vyper/codegen/expr.py 81.08% <100.00%> (+0.66%) ⬆️
vyper/codegen/module.py 89.89% <100.00%> (-0.67%) ⬇️
vyper/codegen/types/types.py 87.94% <100.00%> (+1.20%) ⬆️
vyper/ir/optimizer.py 83.33% <100.00%> (-6.29%) ⬇️
vyper/semantics/types/value/numeric.py 85.05% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfbca3e...66fe490. Read the comment docs.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Mar 28, 2022

This pull request introduces 4 alerts when merging c05deae into ce6c5d7 - view on LGTM.com

new alerts:

  • 4 for Unused import

@charles-cooper charles-cooper enabled auto-merge (squash) March 28, 2022 22:17
@charles-cooper charles-cooper merged commit 1d79873 into vyperlang:master Mar 28, 2022
charles-cooper added a commit that referenced this pull request Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants