Skip to content

Conversation

@sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Nov 21, 2025

Description

This has a noticeable effect (before/after):

   Duration  25.29s (transform 47.80s, setup 14.48s, collect 110.46s, tests 60.00s, environment 20.94s, prepare 452ms)
   Duration  22.11s (transform 18.42s, setup 16.63s, collect 79.83s, tests 54.14s, environment 24.67s, prepare 481ms)

We can avoid the roundtrip because if the module is invalidated, then we will destroy the worker, so we can be sure the module didn't change.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@sheremet-va sheremet-va requested a review from hi-ogawa November 21, 2025 13:54
@sheremet-va sheremet-va merged commit b27e002 into vitest-dev:main Nov 21, 2025
15 of 16 checks passed
@sheremet-va sheremet-va deleted the perf/avoid-roundtrip-if-cached branch November 21, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant