fix: incorrect error message for non-awaited expect.element()

[StyleShit]

Description

Resolves #8953

Flagging the callback happened inside the callback itself, which runs after the check whether it's poll or element, so I flagged it outside the callback

I want to add some tests. Saw that there are tests for poll-no-awaited, but I'm assuming that expect.element tests shouldn't be there and I wasn't sure how to test it. Would be glad to get some help here

[netlify]

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	6a5715f
🔍 Latest deploy log	https://app.netlify.com/projects/vitest-dev/deploys/690c79a8751faf00082d1608
😎 Deploy Preview	https://deploy-preview-8954--vitest-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[sheremet-va]

The error is correct, just the message is wrong.

[sheremet-va]

I don't see how this fixes the message. Please, add a test somewhere in test/browser, probably

[StyleShit]

I don't see how this fixes the message

Determining the error message is based on a flag that's attached to the expect function reference (either expect.poll() or expect.element()).

What happened is that the flagging of expect.element() happens inside the function itself
(basically function expectElement() { addFlag(this, 'expect.element', true) }),
but the check against this flag runs before this function even runs, so it's not flagged yet.

add a test

Added. Took me some time to figure it out...

[Omerisra6]

Hi, new here :)
How does this ensures the right message?

[sheremet-va]

but the check against this flag runs before this function even runs, so it's not flagged yet.

I see, the poll is not called at all if the function is not awaited, so the flag is never set