Skip to content

Conversation

@vitess-bot
Copy link
Contributor

@vitess-bot vitess-bot bot commented Dec 3, 2025

Description

This is a backport of #18972

@vitess-bot vitess-bot bot added Backport This is a backport Component: VDiff Type: Enhancement Logical improvement (somewhere between a bug and feature) labels Dec 3, 2025
@vitess-bot vitess-bot bot requested a review from mattlord as a code owner December 3, 2025 06:19
@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Dec 3, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot requested a review from beingnoble03 as a code owner December 3, 2025 06:19
@github-actions github-actions bot added this to the v23.0.1 milestone Dec 3, 2025
@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.70%. Comparing base (3a4e516) to head (ac0d132).
⚠️ Report is 5 commits behind head on release-23.0.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-23.0   #18978      +/-   ##
================================================
+ Coverage         69.69%   69.70%   +0.01%     
================================================
  Files              1606     1606              
  Lines            214550   214564      +14     
================================================
+ Hits             149535   149570      +35     
+ Misses            65015    64994      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arthurschreiber arthurschreiber merged commit 68d143c into release-23.0 Dec 3, 2025
108 of 110 checks passed
@arthurschreiber arthurschreiber deleted the backport-18972-to-release-23.0 branch December 3, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport This is a backport Component: VDiff Type: Enhancement Logical improvement (somewhere between a bug and feature)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants