Skip to content

Normalize flag names at the pflag level. #18642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arthurschreiber merged 14 commits into from
Sep 15, 2025

test: cleanup

8d1da6f
Select commit
Loading
Failed to load commit list.
Merged

Normalize flag names at the pflag level. #18642

test: cleanup
8d1da6f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 15, 2025 in 0s

67.53% (+67.53%) compared to e89de50

View this Pull Request on Codecov

67.53% (+67.53%) compared to e89de50

Details

Codecov Report

❌ Patch coverage is 11.32075% with 47 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.53%. Comparing base (e89de50) to head (8d1da6f).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/utils/flags.go 20.00% 16 Missing ⚠️
go/cmd/mysqlctl/mysqlctl.go 0.00% 2 Missing ⚠️
go/cmd/mysqlctld/mysqlctld.go 0.00% 2 Missing ⚠️
go/cmd/vtaclcheck/cli/vtactlcheck.go 0.00% 2 Missing ⚠️
go/cmd/vtclient/vtclient.go 0.00% 2 Missing ⚠️
go/cmd/vtctl/vtctl.go 0.00% 2 Missing ⚠️
go/cmd/vtctlclient/main.go 0.00% 2 Missing ⚠️
go/cmd/mysqlctl/command/start.go 0.00% 1 Missing ⚠️
go/cmd/rulesctl/main.go 0.00% 1 Missing ⚠️
go/cmd/topo2topo/topo2topo.go 0.00% 1 Missing ⚠️
... and 16 more
Additional details and impacted files 
@@            Coverage Diff            @@
##           main   #18642       +/-   ##
=========================================
+ Coverage      0   67.53%   +67.53%     
=========================================
  Files         0     1613     +1613     
  Lines         0   263778   +263778     
=========================================
+ Hits          0   178134   +178134     
- Misses        0    85644    +85644

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov