Skip to content

dolthub/dolt#9738 - Add recursive SELECTs #18590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
elianddb wants to merge 1,386 commits into from
Closed

dolthub/dolt#9738 - Add recursive SELECTs #18590

elianddb wants to merge 1,386 commits into from

Conversation

@elianddb
Copy link

@elianddb elianddb commented Aug 27, 2025

fulghum and others added 30 commits March 7, 2024 09:31
@fulghum
Merge pull request #315 from dolthub/james/binary
5f7f589 
support binary charset in table option
@fulghum
Merge branch 'main' into fulghum/com_binlog_prototype
38d9806
@fulghum
Merge branch 'main' into fulghum/com_binlog_prototype
54e6338
@fulghum
Merge branch 'fulghum/com_binlog_prototype' of https://github.com/dol…
c4763c1 
…thub/vitess into fulghum/com_binlog_prototype
@fulghum
Adding support for SHOW REPLICAS
063868e
@fulghum
Adding support for SHOW BINARY LOG STATUS
53ceaf5
@fulghum
Adding support for SHOW BINARY LOGS
b5f0595
@fulghum
Adding new non-reserved keywords to non_reserved_keyword list
919c452
@fulghum
Merge pull request #318 from dolthub/fulghum/binlog_statements
9bc43e5 
Support for more binlog statements
@jycor
make constraint name optional for primary key (#319)
96a83d3 
Co-authored-by: James Cor <[email protected]>
@fulghum
Pulling over latest code from binlog_event_make.go
0bfe319
@fulghum
Fixing bad var name
7a9554f
@fulghum
Moving binlog replica methods to a new extension interface: BinlogRep…
fe290b5 
…licaHandler
@fulghum
Merge branch 'main' into fulghum/com_binlog_prototype
6621ed3
@fulghum
Merge pull request #317 from dolthub/fulghum/com_binlog_prototype
8ee5109 
Port: Support for Vitess server to send binlog events
@fulghum
Porting over support for ComRegisterReplica
05a7b47
@fulghum
Adding a check for a nil GTID set to prevent a message parsing error.
5d2f9f4
@max-hoffman
[ast] walk tableFuncExpr for bind variables
baa4697
@max-hoffman
Merge pull request #321 from dolthub/max/table-func-expr-walk
af0bf0b 
[ast] walk tableFuncExpr for bind variables
@jycor
parse table options into struct (#322)
89f7db8
@fulghum
Adding parser support for SOURCE_AUTO_POSITION
d263462
@fulghum
Adding parser support for SOURCE_AUTO_POSITION
7793754
@nicktobey
Ensure that float values parsed into expressions will always be parse…
1cfa73b 
…d back into floats, not decimals.
@nicktobey
Merge pull request #324 from dolthub/nicktobey/floats
a0bbde8 
Ensure that float values parsed into expressions will always be parsed back into floats, not decimals.
@fulghum
Merge branch 'main' into fulghum/source_auto_position
cc8a2fd
@fulghum
Merge pull request #323 from dolthub/fulghum/source_auto_position
ad95f0d 
Parser support for `SOURCE_AUTO_POSITION`
@fulghum
Various fixes to support dumping binlog events from a primary server:…
241e512 
… exposing a function to flush a connection's buffer, adding constructor functions for more MySQL binlog event types, and fixing incorrect deserialization code.
@fulghum
Merge branch 'main' into fulghum/com_binlog_prototype
f47cd63
@fulghum
Merge pull request #320 from dolthub/fulghum/com_binlog_prototype
65f4774 
Updates for binlog primary protocol
@coffeegoddd
/{.github,go.mod,go.sum}: bump go version
cfededc
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Aug 27, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Aug 27, 2025
@github-actions github-actions bot added this to the v23.0.0 milestone Aug 27, 2025
@elianddb elianddb closed this Aug 27, 2025
@BrewTestBot BrewTestBot mentioned this pull request Nov 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@notfelineit notfelineit Awaiting requested review from notfelineit

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach is a code owner

@derekperkins derekperkins Awaiting requested review from derekperkins derekperkins is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

@timvaillancourt timvaillancourt Awaiting requested review from timvaillancourt timvaillancourt is a code owner

@arthurschreiber arthurschreiber Awaiting requested review from arthurschreiber arthurschreiber is a code owner

@dbussink dbussink Awaiting requested review from dbussink dbussink is a code owner

Assignees

No one assigned

Labels

NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says

Projects

None yet

Milestone

v23.0.0

Development

Successfully merging this pull request may close these issues.

CREATE VIEW should support parentheses around the SELECT statement for MySQL compatibility