Long Running Operations: Ensure eager write lock #21113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch from WriteLock to EagerWriteLock when acquiring the lock for long running operations to ensure proper lock acquisition timing.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a potential race condition in the long-running operation service by changing from lazy lock acquisition (WriteLock) to eager lock acquisition (EagerWriteLock). Following the introduction of lazy locks in #21102, locks requested via WriteLock are queued and only acquired later when needed (e.g., when database access occurs). However, the long-running operation service needs to immediately hold the lock before checking if an operation of the same type is already running to prevent concurrent operations from bypassing this check.
Key Changes
- Changed
scope.WriteLock()toscope.EagerWriteLock()in LongRunningOperationService to ensure immediate lock acquisition before theIsAlreadyRunningcheck
nikolajlauridsen
deleted the
v17/bugfix/long-running-operation-eager-write-lock
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
EagerWriteLockinstead ofWriteLockfor long running operations lock acquisitionDetails
This change ensures proper lock acquisition timing when checking if a long running operation of the same type is already running. With the introduction of lazy locks in #21102, this lock needs to be explicitly eager to maintain the expected behavior.