docs: fix README typos and grammatical errors #478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santoshyadavdev
requested changes
Nov 26, 2023
libs/ngu/carousel/README.md
Outdated
| | `vertical.enabled` | boolean | optional | This option enable the `vertical` direction | | ||
| | `vertical.height` | boolean | optional | This option is used to set the height of the carousel | | ||
| | `animation` | string | optional | It is used to animate the sliding items. currently it only supports `lazy`. more coming soon and also with custom CSS animation option | | ||
| | `custom` | string | optional | It is you to define the purpose of the carousel. Currently, it only supports `banner`, but more options are coming soon, including custom CSS animation option. | |
Member
There was a problem hiding this comment.
| custom | string | optional | It is you to define the purpose of the carousel. Currently, it only supports banner
Contributor
Author
There was a problem hiding this comment.
Sure will update it
README.md
Outdated
| | `custom` | string | optional | It is you to define the purpose of the carousel. currently it only supports `banner`. more coming soon and also with custom css animation option | | ||
| | `RTL` | boolean | optional | This option enable the `rtl` direction and act as rtl. By default it is `ltr` | | ||
| | `animation` | string | optional | It is used to animate the sliding items. currently it only supports `lazy`. more coming soon and also with custom CSS animation option | | ||
| | `custom` | string | optional | It is you to define the purpose of the carousel. Currently, it only supports `banner`, but more options are coming soon, including custom CSS animation option. | |
Member
There was a problem hiding this comment.
| custom | string | optional | It is you to define the purpose of the carousel. Currently, it only supports banner.
sasidharansd
force-pushed
the
fix-readme-typo
branch
from
01ce423 to
176aeb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @santoshyadavdev , was reading through the README file, found few typo's hence dropped a pr to fix those. Lemme know if any changes needed.