Update how isLast is set when data is updated #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if the current slide should be the last slide when dataStream is updated.
This fixes an issue where the dataStream is updated but the carousel
slides do not move. In the current state, isLast will incorrectly be set
to false. With these changes, isLast will stay false if the carousel is
still on the last slide after the data updates
Contributor
|
@santoshyadavdev The context for this PR is, if we create a carousel that can be paged left and right, and we also allow the user to remove items from the carousel. This PR aims to fix that issue. |
Check if the current slide should be the last slide when dataStream is updated. This fixes an issue where the dataStream is updated but the carousel slides do not move. In the current state, isLast will incorrectly be set to false. With these changes, isLast will stay false if the carousel is still on the last slide after the data updates.
…u-carousel into bugfix/last-item-update
Member
|
Thanks, @ralam will get it to release on Thursday. |
santoshyadavdev
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if the current slide should be the last slide when
dataStreamis updated. This fixes an issue where thedataStreamis updated but the carousel slides do not move. In the current state,isLastwill incorrectly be set to false. With these changes,isLastwill stay false if the carousel is still on the last slide after the data updates.I've tested these changes on a local application with this patch.