add a flag for consolor to print SOL info #424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
👍 if it works :-) |
Contributor
|
lgtm |
support/ruby/consolr/bin/consolr
Outdated
| opt.on('-k', '--kick', 'kick if someone is hogging the console') { options[:kick] = true } | ||
| opt.on('-l', '--log LOG', 'System Event Log (SEL) [list|clear]') { |log| options[:log] = log } | ||
| opt.on('-o', '--on', 'turn on node') { options[:on] = true } | ||
| opt.on('-p', '--sol-info', 'get Serial Over LAN (SOL) info') { options[:get_sol_info] = true } |
Contributor
There was a problem hiding this comment.
How did you decide on -p?
Contributor
There was a problem hiding this comment.
Tiny nitpick: i think that in all other cases we're using the long parameter name as the symbol name in the options hash. For instance, --on => options[:on], --kick => options[:kick] etc. Might want to keep with that convention.
Not going to block you on that though. My LGTM still stands.
Contributor
Author
There was a problem hiding this comment.
I changed it to -g for "get-sol-info"
Contributor
|
Please remember to bump the version - https://github.com/tumblr/collins/blob/master/support/ruby/consolr/lib/consolr/version.rb |
Contributor
Author
|
do things look fine now @Primer42? |
Contributor
|
Please rebase and squash before merging. |
sushruta
force-pushed
the
sashi/add-sol-info-consolr
branch
from
b684eaf to
1ebf994
Compare
sushruta
added a commit
that referenced
this pull request
Mar 7, 2016
add a flag for consolor to print SOL info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding SOL info for the host we wish to connect to. This can give us session info in case we need to need to dig deeper into session count and handles.
usage --
consolr --tag <asset_tag> --sol-infoexample output