Skip to content

Conversation

@Gauravtalreja1
Copy link

No description provided.

@evgeni
Copy link
Member

evgeni commented Nov 21, 2025

What is the intent here? The folder does contain two git-tracked inventories right now.

@ehelms ehelms marked this pull request as draft November 24, 2025 19:34
@Gauravtalreja1
Copy link
Author

@evgeni When we deploy using deploy-foreman-development workflow, it adds a few inventories like foreman.example.com, broker.py, quadlet, and localhost inventory, so I feel it would be better to add entire inventories/ dir to gitignore would make more sense to avoid exposing this, wdyt?

@evgeni
Copy link
Member

evgeni commented Nov 25, 2025

The only inventory see created by that workflow is inventories/ip-*.example.com, but I also don't see it ever being used (as that workflow correctly uses --target-host localhost afterwards.
So if the workflow doesn't need the inventory, I'd suggest it shouldn't create it.
And if it's needed, I am sure the workflow can add it to the ignore file?

@ehelms
Copy link
Member

ehelms commented Dec 5, 2025

@Gauravtalreja1 Any updates on needing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants