fix: Correct timeouts variable type definition from optional(bool) to optional(string)
#150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raffraffraff
changed the title
bryantbiggs
changed the title
timeouts variable type definition from optional(bool) to optional(string)
Contributor
Author
|
Christ what does this want from me, I have a day job to get back to. FIX:? Fix:? fix:? fix: Capitalized? |
Member
|
Contributor
Author
|
Thanks! I just got it myself on the last attemt, after looking at another PR, but your rename made it a no-op. |
antonbabenko
pushed a commit
that referenced
this pull request
Oct 28, 2025
## [3.0.2](v3.0.1...v3.0.2) (2025-10-28) ### Bug Fixes * Correct `timeouts` variable type definition from `optional(bool)` to `optional(string)` ([#150](#150)) ([cb116df](cb116df))
Member
|
This PR is included in version 3.0.2 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The type for the variable 'timeouts' is incorrect. When it is passed to the "aws_ec2_transit_gateway" resource, which requires a map of strings, not booleans, it breaks. This probably got missed because timeouts is not in the complete example (I added it there)
Motivation and Context
The 3.0.0 version introduced a very odd change to the variables, switching timeouts type from
map(any)to an object of bools. Makes no sense, and doesn't work at all with theaws_ec2_transit_gatewayresource. The issue would only be detected if the module is used to create a transit gateway with specific timeouts set.Breaking Changes
None.
How Has This Been Tested?
examples/complete/main.tfto demonstrate and validate my change(s)pre-commit run -aon my pull request