feat: replace kwargs with invocation_state in agent APIs #966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackYPCOnline
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
pgrayy
reviewed
Oct 2, 2025
pgrayy
reviewed
Oct 2, 2025
pgrayy
reviewed
Oct 2, 2025
pgrayy
reviewed
Oct 2, 2025
Member
|
Can you add details to the PR description explaining the purpose of this change? |
Unshure
requested changes
Oct 2, 2025
JackYPCOnline
had a problem deploying
to
auto-approve
GitHub Actions
Failure
Unshure
reviewed
Oct 3, 2025
Member
Unshure
left a comment
Unshure
left a comment
There was a problem hiding this comment.
Can you add unit tests for this
mkmeral
reviewed
Oct 3, 2025
Contributor
Author
Actually this change is covered by origin test code but I can add a specific one |
JackYPCOnline
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
afarntrog
reviewed
Oct 3, 2025
afarntrog
reviewed
Oct 3, 2025
Unshure
reviewed
Oct 6, 2025
Co-authored-by: Nick Clegg <[email protected]>
JackYPCOnline
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
zastrowm
previously requested changes
Oct 6, 2025
JackYPCOnline
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
pgrayy
previously approved these changes
Oct 9, 2025
JackYPCOnline
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
JackYPCOnline
force-pushed
the
replace_kwargs
branch
from
664381a to
b14e2f5
Compare
JackYPCOnline
had a problem deploying
to
auto-approve
GitHub Actions
Failure
JackYPCOnline
force-pushed
the
replace_kwargs
branch
from
b14e2f5 to
cf5d4bb
Compare
JackYPCOnline
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
dbschmigelski
approved these changes
Oct 10, 2025
pgrayy
approved these changes
Oct 10, 2025
dbschmigelski
pushed a commit
to dbschmigelski/sdk-python
that referenced
this pull request
Dec 9, 2025
…nts#966) * feat: replace kwargs with invocation_state in agent APIs * fix: handle **kwargs in stream_async. * feat: add a unit test for the change * Update src/strands/agent/agent.py Co-authored-by: Nick Clegg <[email protected]> * tool - executors - concurrent - remove no-op gather (strands-agents#954) * feat(telemetry): updated traces to match OTEL v1.37 semantic conventions (strands-agents#952) * event loop - handle model execution (strands-agents#958) * feat: implement concurrent message reading for session managers (strands-agents#897) Replace sequential message loading with async concurrent reading in both S3SessionManager and FileSessionManager to improve performance for long conversations. Uses asyncio.gather() with run_in_executor() to read multiple messages simultaneously while maintaining proper ordering. Resolves: strands-agents#874 Co-authored-by: Vamil Gandhi <[email protected]> * hooks - before tool call event - cancel tool (strands-agents#964) * fix(telemetry): removed double serialization for events (strands-agents#977) * fix(litellm): map LiteLLM context-window errors to ContextWindowOverflowException (strands-agents#994) * feat: add more tests and adjust invocation_state dic structure * Apply suggestion from @Unshure Co-authored-by: Nick Clegg <[email protected]> * fix: adjust **kwargs in multiagent primitives --------- Co-authored-by: Nick Clegg <[email protected]> Co-authored-by: Patrick Gray <[email protected]> Co-authored-by: poshinchen <[email protected]> Co-authored-by: Vamil Gandhi <[email protected]> Co-authored-by: Vamil Gandhi <[email protected]> Co-authored-by: ratish <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current Agent APIs (Agent.call, Agent.invoke_async, Agent.stream_async) accept arbitrary keyword arguments via **kwargs, which are then converted to invocation_state and passed through the execution pipeline to tools. This has the downside that any new parameter we want to add to these methods could potentially conflict with user-provided kwargs, making it impossible to evolve the API without breaking changes.
Change:
Add invocation_state as parameter to agent's APIs.
Still keep **kwargs for now to keep backward compatible, merge **kwargs to invocation_state instead.
Related Issues
#919
Documentation PR
Type of Change
Bug fix
New feature
Breaking change
Documentation update
Other (please describe):
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.