generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 535
feat(hooks): Mark ModelCall and ToolCall events as non-experimental #926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zastrowm
merged 2 commits into
strands-agents:main
from
zastrowm:non_experimental_hooks
Sep 26, 2025
Merged
feat(hooks): Mark ModelCall and ToolCall events as non-experimental #926
zastrowm
merged 2 commits into
strands-agents:main
from
zastrowm:non_experimental_hooks
Sep 26, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses strands-agents#667 - we haven't seen any huge deficiencies in these and we need to stabilize hooks As part of this change we renamed the events to clarify naming and reduce verbosity: - BeforeToolInvocationEvent -> BeforeToolCallEvent - AfterToolInvocationEvent -> AfterToolCallEvent - BeforeModelInvocationEvent -> BeforeModelCallEvent - AfterModelInvocationEvent -> AfterModelCallEvent Part of the motivation of the rename is to avoid confusion with BeforeInvocationEvent and BeforeToolInvocation & BeforeModelInvocationEvent, as we've seen folks confusing them quite a bit. These changes are backwards compatible as the experimental events still exist; we can remove those after a release or two
Unshure
reviewed
Sep 25, 2025
Unshure
approved these changes
Sep 26, 2025
cagataycali
approved these changes
Sep 26, 2025
zastrowm
added a commit
to zastrowm/docs
that referenced
this pull request
Sep 26, 2025
In strands-agents/sdk-python/pull/926 we've released these hooks (and done a rename) so update the docs to account for it Part of strands-agents/sdk-python#667
6 tasks
zastrowm
added a commit
to strands-agents/docs
that referenced
this pull request
Sep 26, 2025
In strands-agents/sdk-python/pull/926 we've released these hooks (and done a rename) so update the docs to account for it Part of strands-agents/sdk-python#667 Co-authored-by: Mackenzie Zastrow <[email protected]>
mkmeral
pushed a commit
to mkmeral/strands-docs
that referenced
this pull request
Oct 1, 2025
In strands-agents/sdk-python/pull/926 we've released these hooks (and done a rename) so update the docs to account for it Part of strands-agents/sdk-python#667 Co-authored-by: Mackenzie Zastrow <[email protected]>
dbschmigelski
pushed a commit
to dbschmigelski/sdk-python
that referenced
this pull request
Dec 9, 2025
…trands-agents#926) feat(hooks): Mark ModelCall and ToolCall events as non-experimental Addresses strands-agents#667 - we haven't seen any huge deficiencies in these and we need to stabilize hooks As part of this change we renamed the events to clarify naming and reduce verbosity: - BeforeToolInvocationEvent -> BeforeToolCallEvent - AfterToolInvocationEvent -> AfterToolCallEvent - BeforeModelInvocationEvent -> BeforeModelCallEvent - AfterModelInvocationEvent -> AfterModelCallEvent Part of the motivation of the rename is to avoid confusion with BeforeInvocationEvent and BeforeToolInvocation & BeforeModelInvocationEvent, as we've seen folks confusing them quite a bit. These changes are backwards compatible as the experimental events still exist; we can remove those after a release or two --------- Co-authored-by: Mackenzie Zastrow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #667 - we haven't seen any huge deficiencies in these and we need to stabilize hooks
As part of this change we renamed the events to clarify naming and reduce verbosity:
BeforeToolInvocationEvent->BeforeToolCallEventAfterToolInvocationEvent->AfterToolCallEventBeforeModelInvocationEvent->BeforeModelCallEventAfterModelInvocationEvent->AfterModelCallEventPart of the motivation of the rename is to avoid confusion with BeforeInvocationEvent and BeforeToolInvocation & BeforeModelInvocationEvent, as we've seen folks confusing them quite a bit.
API Bar Raise
The new names need to be API bar-raised.
The existing events that are not changing are as follows:
AgentInitializedEventAgent.__init__.BeforeInvocationEvent__call__,stream_async, orstructured_output)AfterInvocationEventMessageAddedEventThe proposed events that are being renamed:
BeforeModelInvocationEventBeforeModelCallEventAfterModelInvocationEventAfterModelCallEventBeforeToolInvocationEventBeforeToolCallEventAfterToolInvocationEventAfterToolCallEventBackwards compatibility
Related Issues
#667
Documentation PR
TBD
Type of Change
New feature
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.