generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 535
session manager - prevent file path injection #680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgrayy
commented
Aug 15, 2025
pgrayy
commented
Aug 15, 2025
pgrayy
commented
Aug 15, 2025
pgrayy
commented
Aug 15, 2025
zastrowm
previously approved these changes
Aug 15, 2025
Member
zastrowm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits/organizational items
pgrayy
commented
Aug 15, 2025
awsarron
approved these changes
Aug 15, 2025
dbschmigelski
pushed a commit
to dbavro19/sdk-python
that referenced
this pull request
Aug 28, 2025
7 tasks
This was referenced Sep 17, 2025
Closed
Unshure
pushed a commit
to Unshure/sdk-python
that referenced
this pull request
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing a vulnerability in the file and s3 session managers where customers can manipulate the storage paths through session id.
Currently,
session_idis appended to the storage path without first being sanitized. Doing the above could lead the session manager to add or remove files from a restricted directory. This is a risk for Strands customers that obtainsession_idfrom a third party.This PR fixes the issue by raising an exception if the session_id contains separators.
Related Issues
Issue raised to the team internally.
Documentation PR
Updated the API docs through docstrings in this PR.
Type of Change
Bug fix
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepare: Wrote new unit tests.Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.