Fix agent default callback handler #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Type Annotation Improvements: - Changed kwargs: Any to kwargs: Dict[str, Any] in _run_loop method - Changed dict[str, Any] to Dict[str, Any] in _execute_event_loop_cycle - Improved all Callable type annotations to Callable[..., Any] 2. Default Parameter Value Fix: - Changed callback_handler default from PrintingCallbackHandler() to None - This avoids the anti-pattern of using a mutable default parameter value 3. Parameter Mutation Protection: - Added .copy() to kwargs in both __call__ and stream_async methods - This prevents modifications to the kwargs dictionary from affecting the original
This addresses PR feedback by: 1. Adding a sentinel object _DEFAULT_CALLBACK_HANDLER to distinguish between default and explicit None 2. Using the sentinel as the default parameter value for callback_handler 3. Creating a new PrintingCallbackHandler instance when the sentinel is used 4. Preserving the behavior where explicitly passing None uses null_callback_handler 5. Updating the docstring to reflect these changes
Unshure
approved these changes
Jun 3, 2025
jer96
pushed a commit
to lukehau/sdk-python
that referenced
this pull request
Jun 3, 2025
Co-authored-by: Sourabh Sarupria <[email protected]> Co-authored-by: Sourabh Sarupria <[email protected]>
15 tasks
Unshure
pushed a commit
to Unshure/sdk-python
that referenced
this pull request
Jul 2, 2025
Co-authored-by: Sourabh Sarupria <[email protected]> Co-authored-by: Sourabh Sarupria <[email protected]>
jsamuel1
pushed a commit
to jsamuel1/sdk-python
that referenced
this pull request
Jul 9, 2025
Co-authored-by: Sourabh Sarupria <[email protected]> Co-authored-by: Sourabh Sarupria <[email protected]>
dbschmigelski
pushed a commit
to Ketansuhaas/sdk-python
that referenced
this pull request
Jul 24, 2025
Co-authored-by: Sourabh Sarupria <[email protected]> Co-authored-by: Sourabh Sarupria <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix agent default callback handler
This PR expands on #68.
Related Issues
N/A
Documentation PR
N/A
Type of Change
Testing
hatch fmthatch run test-linthatch test --allChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.