feat(bedrock): Add support for server-side tools (system tools) #1318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for server-side tools that are handled within the model invocation. When Bedrock returns tool use and tool response together with a specific (server_tool_use) type, the SDK now correctly: - Distinguishes server-side tools (like nova_grounding) from client-side tools - Does NOT override stopReason to 'tool_use' for server-side tools - Tracks tool results to determine if tools have already been executed This enables features like Nova Web Grounding to work correctly without triggering infinite loops or unnecessary tool execution attempts. Changes: - Updated streaming handler to track tool types and results - Added _has_client_side_tools_to_execute() helper method - Updated non-streaming handler to use the new helper - Added comprehensive tests for server-side tool handling
danilop
requested a deployment
to
manual-approval
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for server-side tools that are handled within the model invocation. When Bedrock returns tool use and tool response together with a specific (
server_tool_use) type, the SDK now correctly:nova_grounding) from client-side toolsstopReasontotool_usefor server-side toolsThis enables features like Nova Web Grounding to work correctly without triggering infinite loops or unnecessary tool execution attempts.
Changes:
_has_client_side_tools_to_execute()helper methodRelated Issues
Fixes #1154
Documentation PR
N/A
Type of Change
Bug fix / New feature
Testing
Tested with Nova Web Grounding in both streaming and non-streaming modes.
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.