Skip to content

Conversation

@pgrayy
Copy link
Member

@pgrayy pgrayy commented Dec 3, 2025

Description

MCP recently changed ElicitRequestParams to a Union (commit). This breaks our elicitation integ test. Fixing by utilizing the new elicit method.

Related Issues

N/A

Documentation PR

N/A

Type of Change

Bug fix

Testing

How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

  • I ran hatch run prepare
  • I ran hatch test tests_integ/mcp/test_mcp_elicitation.py

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@pgrayy pgrayy changed the title mcp - elicitation - fix server request mcp - elicitation - fix server request test Dec 3, 2025
@pgrayy pgrayy marked this pull request as ready for review December 3, 2025 17:05
@pgrayy pgrayy merged commit 9fa818e into strands-agents:main Dec 3, 2025
24 checks passed
@pgrayy pgrayy deleted the elicitation-test branch December 4, 2025 17:09
dbschmigelski pushed a commit to dbschmigelski/sdk-python that referenced this pull request Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants