Updating Bedrock Converse API citations format to handle web citations #1168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilop
had a problem deploying
to
manual-approval
GitHub Actions
Failure
danilop
had a problem deploying
to
manual-approval
GitHub Actions
Failure
danilop
had a problem deploying
to
manual-approval
GitHub Actions
Failure
dbschmigelski
requested changes
Nov 13, 2025
| domain: str | ||
|
|
||
|
|
||
| class DocumentChunkLocation(TypedDict, total=False): |
Member
There was a problem hiding this comment.
Hi, we have to preserve backwards compatibility. So we cannot simply remove these classes.
These are typeddicts, so I see the argument that it would not be possible from someone to leverage
CitationLocation = Union[DocumentCharLocation, DocumentChunkLocation, DocumentPageLocation] to do instanceof checks in the first place. But this still needs to be workshopped to avoid breaking changes
|
hi team, any update on this? One of my customer is also looking forward for this feature support to test out Nova Web Grounding. |
danilop
requested a deployment
to
manual-approval
GitHub Actions
Waiting
Author
|
All types should be back now for backward compatibility. |
…rse API Add support for web-based citations in addition to document-based citations: - Added WebLocation TypedDict to citations.py with url and domain fields - Updated CitationLocation union to include WebLocation - Updated bedrock.py to filter web citation fields (url, domain only) - Handle optional citation fields gracefully (title, location, sourceContent) - Added tests for web citations, document citations, and edge cases
danilop
requested a deployment
to
manual-approval
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for web-based citations in the Bedrock Converse API, enabling the SDK to handle citations from web sources in addition to document-based citations.
Changes:
WebLocationTypedDict tosrc/strands/types/citations.pywithurlanddomainfieldsCitationLocationunion type to include the newWebLocationtypesrc/strands/models/bedrock.pyto handle web-based citationsAll citation location types (document-based and web-based) are now supported as per the updated Bedrock Converse API specification.
Related Issues
This was a blocking issue for #1154
Documentation PR
N/A
Type of Change
New feature
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.