generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 536
share thread context #1146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
share thread context #1146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
pgrayy
commented
Nov 6, 2025
pgrayy
commented
Nov 6, 2025
pgrayy
commented
Nov 6, 2025
zastrowm
approved these changes
Nov 7, 2025
mehtarac
approved these changes
Nov 7, 2025
JackYPCOnline
added a commit
that referenced
this pull request
Nov 20, 2025
* fix: fix swarm session management integ test. * share thread context (#1146) * async hooks (#1119) * fix: remove debug lines --------- Co-authored-by: Patrick Gray <[email protected]>
pgrayy
added a commit
to pgrayy/sdk-python
that referenced
this pull request
Nov 24, 2025
* fix: fix swarm session management integ test. * share thread context (strands-agents#1146) * async hooks (strands-agents#1119) * fix: remove debug lines --------- Co-authored-by: Patrick Gray <[email protected]>
dbschmigelski
pushed a commit
to dbschmigelski/sdk-python
that referenced
this pull request
Dec 9, 2025
dbschmigelski
pushed a commit
to dbschmigelski/sdk-python
that referenced
this pull request
Dec 9, 2025
* fix: fix swarm session management integ test. * share thread context (strands-agents#1146) * async hooks (strands-agents#1119) * fix: remove debug lines --------- Co-authored-by: Patrick Gray <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
agent(...)is a sync invocation that internally invokesstream_async. To runstream_asyncin a sync context, we create a thread so as to isolate the creation of an async event loop. As part of that thread creation, we are not copying contextvars from the main thread. Customers are asking to have this context copied. The thread we create is not meant for context isolation, only async event loop isolation.Note, I was initially hesitant to make this change because of the following scenario:
I think this is okay though because the use of threads is an internal implementation detail of Strands. Customers are not designing their tools with our use of threads in mind. Additionally, the use of threads here is specifically meant for asyncio event loop isolation, not context isolation. Thus, this is a bug we are fixing here.
Another note, customers may also want to copy context out of the agent threads. However, modifications made to a contextvar in a subthread do not propagate to the parent thread. The context copy only goes one way.
Shout outs
Shout out to @patrickbradshawdallas for proposing this change in #946.
Related Issues
Documentation PR
Not necessary as this is an implementation detail of Strands.
Type of Change
Bug fix
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run preparehatch test tests_integ/tools/test_thread_context.py: New integ test for thread context sharing.Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.