generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 536
fix: Don't bail out if there are no tool_uses #1087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partial fix to strands-agents#1069 - previously the agent would prematurely exit if the agent generated a tool with an invalid name; this avoids that by ensuring the agent loop continues with zero tool-uses.
When attempting to run tests from the IDE I was running into dependencies which were importing types from the test module. It seems to be a well-known problem: - https://stackoverflow.com/questions/36669895/site-py-attributeerror-module-object-has-no-attribute-moduletype-upon-runn - https://stackoverflow.com/questions/36250353/importing-a-library-from-or-near-a-script-with-the-same-name-raises-attribute And the quick solution is just to remove the __init__ from the test types module.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
pgrayy
previously approved these changes
Oct 24, 2025
mehtarac
previously approved these changes
Oct 24, 2025
Unshure
approved these changes
Oct 24, 2025
dbschmigelski
approved these changes
Oct 24, 2025
This was referenced Oct 24, 2025
dbschmigelski
pushed a commit
to schnetler/sdk-python
that referenced
this pull request
Nov 12, 2025
Partial fix to strands-agents#1069 - previously the agent would prematurely exit if the agent generated a tool with an invalid name; this avoids that by ensuring the agent loop continues with zero tool-uses. --------- Co-authored-by: Mackenzie Zastrow <[email protected]>
dbschmigelski
pushed a commit
to dbschmigelski/sdk-python
that referenced
this pull request
Dec 9, 2025
Partial fix to strands-agents#1069 - previously the agent would prematurely exit if the agent generated a tool with an invalid name; this avoids that by ensuring the agent loop continues with zero tool-uses. --------- Co-authored-by: Mackenzie Zastrow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First fix for part of #1069
Previous to this PR, the flow was:
If the agent generates an invalid tool name (say
tool with spaces), the flow ends up being:event_loop._handle_tool_executionwhich callsvalidate_and_prepare_toolsis invoked. The validation fails which has two side-effects:INVALID_TOOL_NAMEAt (4) above the loop should instead continue as normal and pass flow back to the model which is what this PR does.
AFAICT the "bail out if there are no tool-uses" made sense back before we had the full Agent interface and you had to handle tool invocations yourself; however, we should never be returning out of the loop with
tool_usenow as we manage the tool calling on behalf of the agent and we don't guide folks to check the stop_reason for cases like this. AKA: we need to handle this automatically.Notes
This PR also removes
__init__from the test types module - when attempting to run tests from the IDE I was running into dependencies which were importing types from the test module.It seems to be a well-known problem:
And the solution is just to remove the init from the test types module.
Related Issues
#1069
Documentation PR
N/A
Type of Change
Bug fix
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.