Investigation: Remove Windows support hacks for testing #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This branch removes several hacks that were added for Windows support to investigate which ones are actually necessary: 1. Remove dead `findToolDir` and `expandToolDir` functions - These now just return Nothing/identity, so remove them entirely - Update callers in Settings/IO.hs and Session.hs 2. Revert T23142.hs module name from Main back to T23142 3. Adopt upstream ghc-9.14 T20494-obj.c (use printf/fflush uniformly) 4. Remove fragile(0) from T25374/all.T 5. Remove fragile(0) from T25240/all.T The purpose of this branch is to run CI and observe which tests fail, to understand which hacks are truly necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This branch removes several hacks that were added for Windows support to investigate which ones are actually necessary.
Changes made:
Remove dead
findToolDirandexpandToolDirfunctionsRevert T23142.hs module name from
Mainback toT23142Adopt upstream ghc-9.14 T20494-obj.c (use
printf/fflushuniformly instead of conditionaldprintf/fsync)Remove
fragile(0)from T25374/all.TRemove
fragile(0)from T25240/all.TPurpose
The purpose of this branch is to run CI and observe which tests fail, to understand which hacks are truly necessary for Windows support.
Test plan