Deprecate -dynamic-too: remove duplicate object file generation #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit deprecates the -dynamic-too flag and removes the infrastructure that generated separate .dyn_o and .dyn_hi files alongside regular .o and .hi files. Key changes: - Flag -dynamic-too now emits a deprecation warning and is a no-op - Remove auto-enablement of -dynamic-too for TemplateHaskell - Remove pipeline double-run that generated both static and dynamic objects - Remove DynamicTooState type and dynamicNow field from DynFlags - Remove dynamicTooState and setDynamicNow functions - Unify dyn/non-dyn file paths (mkDynObjPath = mkObjPath, etc.) - Remove dynamic interface loading and checking - Update linker to use .o files for dynamic loading The ModLocation fields (ml_dyn_obj_file, ml_dyn_hi_file) are kept for API compatibility but now return the same paths as their non-dyn counterparts. Build systems that rely on .dyn_o files will need to be updated to use regular .o files instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR deprecates the
-dynamic-tooflag and removes the infrastructure that generated separate.dyn_oand.dyn_hifiles alongside regular.oand.hifiles.-dynamic-tooflag now emits a deprecation warning and is a no-op.dyn_oor.dyn_hifiles.oand.hifiles are generatedChanges
GHC/Driver/Session.hsGHC/Driver/Downsweep.hsdynamic_too_enableauto-enablementGHC/Driver/Pipeline.hsGHC/Driver/DynFlags.hsDynamicTooState,dynamicNow,setDynamicNowGHC/Driver/Main.hsGHC/Driver/Pipeline/Execute.hsdynamicNowpath checksGHC/Iface/Load.hsload_dynamic_too*functionsGHC/Iface/Recomp.hscheck_dyn_hilogicGHC/Tc/Utils/Monad.hswithoutDynamicNowGHC/Unit/Finder.hsmkDynObjPath = mkObjPath,mkDynHiPath = mkHiPathGHC/Linker/Loader.hsdyn_obj_file = obj_fileGHC/Linker/Deps.hsBreaking Changes
.dyn_ofiles will need to be updated to use regular.ofiles-dynamic-tooflag no longer has any effect (deprecation warning emitted)Test plan
-dynamic-too.oand.hifiles are produced (no.dyn_oor.dyn_hi)