Concurrent image pull

[hellt]

fix #2091

[codecov]

Codecov Report

Attention: Patch coverage is 30.76923% with 18 lines in your changes missing coverage. Please review.

Project coverage is 53.66%. Comparing base (2860de7) to head (0e51008).

Files with missing lines	Patch %	Lines
core/config.go	44.44%	7 Missing and 3 partials ⚠️
mocks/mocknodes/node.go	0.00%	8 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2671      +/-   ##
==========================================
- Coverage   53.68%   53.66%   -0.02%     
==========================================
  Files         205      205              
  Lines       21794    21815      +21     
==========================================
+ Hits        11700    11707       +7     
- Misses       8872     8884      +12     
- Partials     1222     1224       +2     

Files with missing lines	Coverage Δ
nodes/default_node.go	65.79% <ø> (+0.38%)	⬆️
nodes/node.go	56.00% <ø> (ø)
mocks/mocknodes/node.go	4.82% <0.00%> (-0.14%)	⬇️
core/config.go	70.38% <44.44%> (-1.05%)	⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull Request Overview

This PR implements concurrent image pulling functionality to improve deployment performance by pulling container images in parallel instead of sequentially. The changes refactor the image pulling logic from individual node deployment checks to a centralized concurrent approach.

• Introduces concurrent image pulling with deduplication to avoid pulling the same image multiple times
• Refactors image pulling from node-level sequential operations to topology-level parallel operations
• Updates logging format and variable naming for consistency

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
runtime/docker/docker.go	Updates parameter naming and logging format in PullImage method
nodes/node.go	Adds PullImage method to Node interface
nodes/default_node.go	Removes image pulling from CheckDeploymentConditions
mocks/mocknodes/node.go	Adds mock implementation for new PullImage method
core/image.go	Implements concurrent image pulling logic with deduplication
core/config.go	Integrates concurrent image pulling into topology validation

Comments suppressed due to low confidence (1)

core/image.go:77

• The variable name 'imageKey' is used both as the loop variable (line 70) and as a new variable (line 76), which shadows the outer variable. Consider renaming this to 'cacheKey' or 'pullKey' to avoid confusion.

		imageKey := fmt.Sprintf("%s:%s", imageName, node.Config().ImagePullPolicy)