-
Notifications
You must be signed in to change notification settings - Fork 181
JP-4122: Fix attribute error in combine_1d log message #9848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b359f4e to
6210467
Compare
|
Regression tests: Failures are all unrelated. I'll run again when tests on main are clear. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9848 +/- ##
==========================================
+ Coverage 84.15% 85.41% +1.25%
==========================================
Files 366 366
Lines 37800 37812 +12
==========================================
+ Hits 31812 32297 +485
+ Misses 5988 5515 -473 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
emolter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix looks fine to me, pending clean regtests. I assume you checked the original data that caused the failure?
Yes -- the test data is jw03788-o007_20250917t012349_spec2_00004_asn.json. With this change, the master_background_mos step warns for three background spectra with no valid flux values but continues processing with the remaining 14 valid spectra. |
4ca968b to
6cce887
Compare
Resolves JP-4122
Fix a crash in the master background step for NIRSpec MOS data. When the input background spectra contain no valid flux values, the step issues a warning message. The warning was introduced in #9625 to address some failures in WFSS mode, so was tested with WFSS data. The crash comes from an attempt to log the group_id for the spectrum, which is an attribute that exists for WFSS spectra but not for MOS spectra.
The fix here is to modify the log message to record group_id only if it's present in the datamodel. I added a unit test for this edge case with non-WFSS data.
Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)docs/pageokify_regteststo update the truth files