Skip to content

Conversation

@emolter
Copy link
Collaborator

@emolter emolter commented Sep 12, 2025

This PR adds a regression test for the wfss_contam step for NIRISS.

The test is analogous to the one that already exists for NIRCam. It runs the step with all the default options, except that all the intermediate files are saved. The segmentation map has been altered to contain only 15 sources instead of ~4000 to reduce runtime.

Tasks

  • If you have a specific reviewer in mind, tag them.
  • add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@emolter
Copy link
Collaborator Author

emolter commented Sep 12, 2025

@codecov
Copy link

codecov bot commented Sep 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.41%. Comparing base (94c0254) to head (23f7b0d).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9830      +/-   ##
==========================================
+ Coverage   83.38%   83.41%   +0.03%     
==========================================
  Files         366      366              
  Lines       37770    37784      +14     
==========================================
+ Hits        31493    31518      +25     
+ Misses       6277     6266      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@emolter emolter marked this pull request as ready for review September 15, 2025 16:36
@emolter emolter requested a review from a team as a code owner September 15, 2025 16:36
@emolter
Copy link
Collaborator Author

emolter commented Sep 15, 2025

intermittent issues on Friday with crashing processes were thankfully unrelated (also present for one of the nightly runs) and tests are now passing on a rerun of the link above.

Copy link
Collaborator

@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks for the additional coverage!

@melanieclarke melanieclarke enabled auto-merge (squash) September 16, 2025 18:40
@melanieclarke melanieclarke merged commit 5cfc2de into spacetelescope:main Sep 16, 2025
24 checks passed
@emolter emolter deleted the wfss-contam-regtest branch September 16, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants