JP-4075: Raise error for no slits selected

[melanieclarke]

Resolves JP-4075

Modify the behavior for the arguments to extract_2d that allow selecting specific NIRSpec slits or sources. If the arguments are specified, but none of the slits are valid, raise a NoDataOnDetectorError exception.

Also address a small bug that causes the step to fail if called on a filename instead of a datamodel.

Tasks

• If you have a specific reviewer in mind, tag them.
• add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
• Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
  • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • start a regression test and include a link to the running job (click here for instructions)
    • Do truth files need to be updated ("okified")?
      • after the reviewer has approved these changes, run okify_regtests to update the truth files
• if a JIRA ticket exists, make sure it is resolved properly

[melanieclarke]

Regression tests:
https://github.com/spacetelescope/RegressionTests/actions/runs/17443430879

All passing.

[codecov]

Codecov Report

❌ Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.38%. Comparing base (94c0254) to head (30cd483).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
jwst/extract_2d/extract_2d_step.py	40.00%	3 Missing ⚠️
jwst/extract_2d/nirspec.py	85.71%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #9794   +/-   ##
=======================================
  Coverage   83.38%   83.38%           
=======================================
  Files         366      366           
  Lines       37770    37768    -2     
=======================================
+ Hits        31493    31494    +1     
+ Misses       6277     6274    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[emolter]

It looks like this PR changes the behavior of select_slits() when both slit_names and source_ids are None. On main it appears that this would cause all slits to be selected. But I see here that this now raises a NoDataOnDetectorError when both are None (this case has been added to the tests as well). What am I missing here?

[emolter]

Code looks good to me, I didn't run it myself though

[stscirij]

Looks good to me

[tapastro]

👍