Skip to content

Conversation

@zacharyburnett
Copy link
Collaborator

uses a common .pre-commit-config.yaml with other repositories in pipeline dependencies

As of the creation of this PR, checks that would change any files are commented out.

Tasks

  • If you have a specific reviewer in mind, tag them.
  • add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@codecov
Copy link

codecov bot commented Aug 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.49%. Comparing base (58cc165) to head (a039847).
⚠️ Report is 229 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9779   +/-   ##
=======================================
  Coverage   82.49%   82.49%           
=======================================
  Files         366      366           
  Lines       37134    37134           
=======================================
  Hits        30633    30633           
  Misses       6501     6501           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zacharyburnett zacharyburnett marked this pull request as ready for review August 28, 2025 13:14
@zacharyburnett zacharyburnett requested a review from a team as a code owner August 28, 2025 13:14
Copy link
Collaborator

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zacharyburnett zacharyburnett force-pushed the pre-commit/consistency branch from 4d6e2dd to 606c021 Compare August 28, 2025 16:02
@zacharyburnett zacharyburnett force-pushed the pre-commit/consistency branch from 606c021 to cb6a696 Compare August 28, 2025 17:35
@zacharyburnett zacharyburnett merged commit be2a1ed into spacetelescope:main Aug 29, 2025
28 checks passed
@zacharyburnett zacharyburnett deleted the pre-commit/consistency branch August 29, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants