-
Notifications
You must be signed in to change notification settings - Fork 180
consistent pre-commit config
#9779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zacharyburnett
merged 3 commits into
spacetelescope:main
from
zacharyburnett:pre-commit/consistency
Aug 29, 2025
Merged
consistent pre-commit config
#9779
zacharyburnett
merged 3 commits into
spacetelescope:main
from
zacharyburnett:pre-commit/consistency
Aug 29, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9779 +/- ##
=======================================
Coverage 82.49% 82.49%
=======================================
Files 366 366
Lines 37134 37134
=======================================
Hits 30633 30633
Misses 6501 6501 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zacharyburnett
commented
Aug 27, 2025
braingram
approved these changes
Aug 28, 2025
Collaborator
braingram
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
pllim
reviewed
Aug 28, 2025
pllim
reviewed
Aug 28, 2025
4d6e2dd to
606c021
Compare
606c021 to
cb6a696
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uses a common
.pre-commit-config.yamlwith other repositories in pipeline dependenciesAs of the creation of this PR, checks that would change any files are commented out.
Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)docs/pageokify_regteststo update the truth files