JP-4102: Fix Potential Memory Leak and Remove Unused Code in Cube Build

[kmacdonald-stsci]

Resolves JP-4102

This PR addresses potential memory leaks. Array allocation wasn't being validated and wasn't being freed upon error.

Additionally, this PR removed unused code. A block of code performed computation not used anywhere.

Regression test: https://github.com/spacetelescope/RegressionTests/actions/runs/17265653993

Tasks

• If you have a specific reviewer in mind, tag them.
• add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
• Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
  • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • start a regression test and include a link to the running job (click here for instructions)
    • Do truth files need to be updated ("okified")?
      • after the reviewer has approved these changes, run okify_regtests to update the truth files
• if a JIRA ticket exists, make sure it is resolved properly

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.59%. Comparing base (708d74d) to head (27c1542).
⚠️ Report is 220 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9778      +/-   ##
==========================================
+ Coverage   82.57%   82.59%   +0.01%     
==========================================
  Files         366      366              
  Lines       37292    37292              
==========================================
+ Hits        30794    30801       +7     
+ Misses       6498     6491       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[pllim]

Thanks!

[jemorrison]

LGTM. Good catch on that memory leak.

[pllim]

I think we should merge this. Thanks!

[melanieclarke]

Looks good, on the strength of Jane's review and the passing tests. Thanks for the clean up!