-
Notifications
You must be signed in to change notification settings - Fork 181
JP-3948: Use wavelengthrange reference file information in white light step #9650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9650 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 367 367
Lines 37332 37356 +24
=====================================
- Misses 37332 37356 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
regtests https://github.com/spacetelescope/RegressionTests/actions/runs/16302336812 single regtest failure for soss white light is expected. see JIRA ticket for details |
melanieclarke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thanks for the test coverage! A few minor requests.
It looks like only the WhiteLightStep.process function is missing coverage now - can we add a couple quick tests for it here?
|
Hopefully 541e92b addresses all the comments, let me know if I missed anything |
melanieclarke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good!
Resolves JP-3948
Closes #9311
This PR allows the white light step to read in different default wavelength ranges for different orders/filters from a reference file for NIRISS SOSS data.
Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)docs/pageokify_regteststo update the truth files