Skip to content

Conversation

@emolter
Copy link
Collaborator

@emolter emolter commented Jul 15, 2025

Resolves JP-3948

Closes #9311

This PR allows the white light step to read in different default wavelength ranges for different orders/filters from a reference file for NIRISS SOSS data.

Tasks

  • If you have a specific reviewer in mind, tag them.
  • add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@codecov
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

❌ Patch coverage is 0% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (8409d2b) to head (59ebe67).
⚠️ Report is 362 commits behind head on main.

Files with missing lines Patch % Lines
jwst/white_light/white_light.py 0.00% 18 Missing ⚠️
jwst/white_light/white_light_step.py 0.00% 17 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #9650   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files        367     367           
  Lines      37332   37356   +24     
=====================================
- Misses     37332   37356   +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@emolter emolter added this to the Build 12.1 milestone Jul 15, 2025
@emolter
Copy link
Collaborator Author

emolter commented Jul 15, 2025

regtests https://github.com/spacetelescope/RegressionTests/actions/runs/16302336812

single regtest failure for soss white light is expected. see JIRA ticket for details

@emolter emolter marked this pull request as ready for review July 15, 2025 20:35
@emolter emolter requested review from a team as code owners July 15, 2025 20:35
@emolter emolter requested a review from melanieclarke July 15, 2025 20:35
Copy link
Collaborator

@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks for the test coverage! A few minor requests.

It looks like only the WhiteLightStep.process function is missing coverage now - can we add a couple quick tests for it here?

@emolter
Copy link
Collaborator Author

emolter commented Jul 16, 2025

Hopefully 541e92b addresses all the comments, let me know if I missed anything

Copy link
Collaborator

@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good!

@emolter emolter enabled auto-merge (squash) July 16, 2025 16:22
@emolter emolter merged commit 137df41 into spacetelescope:main Jul 16, 2025
24 checks passed
@emolter emolter deleted the JP-3948 branch July 16, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow SOSS whitelight step to use different wavelength ranges for different spectral orders

2 participants