Skip to content

Conversation

@pllim
Copy link
Collaborator

@pllim pllim commented Jul 15, 2025

Closes #9385

Unless users are doing star imports on the affected modules, which they should not in the first place, there is no change that needs to be documented in change log.

grep "__all__" -Lr . | grep "\.py" | grep -v "test" would tell you most of them, minus a couple of obvious ones you can ignore.

Partially assisted by generate_all.

TODO

  • Add __all__ to remaining modules.
  • grep again to make sure I didn't miss anything.

Tasks

@codecov
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.44%. Comparing base (5d07960) to head (23d9688).
⚠️ Report is 322 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9646      +/-   ##
==========================================
+ Coverage   80.37%   80.44%   +0.07%     
==========================================
  Files         367      367              
  Lines       37265    37407     +142     
==========================================
+ Hits        29951    30093     +142     
  Misses       7314     7314              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pllim pllim force-pushed the all-for-one-one-for-all branch from 308a204 to c2e2874 Compare July 15, 2025 20:42
@pllim

This comment was marked as resolved.

@pllim pllim force-pushed the all-for-one-one-for-all branch from 8c222a8 to 23d9688 Compare July 21, 2025 20:27
@pllim pllim requested a review from melanieclarke July 21, 2025 21:17
Copy link
Collaborator

@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks fine to me. Setting up __all__ should do no harm, and we can always add or remove to what's included here as we go. I checked, and it looks like the changes here do not impact documentation for the places we've included automodapi.

Thanks again for tidying up!

@melanieclarke melanieclarke merged commit 4bbd9cb into spacetelescope:main Jul 22, 2025
32 checks passed
@pllim pllim deleted the all-for-one-one-for-all branch July 22, 2025 15:26
@melanieclarke melanieclarke added this to the Build 12.1 milestone Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment