-
Notifications
You must be signed in to change notification settings - Fork 181
Add __all__ for non-test and non-doc modules #9646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add __all__ for non-test and non-doc modules #9646
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9646 +/- ##
==========================================
+ Coverage 80.37% 80.44% +0.07%
==========================================
Files 367 367
Lines 37265 37407 +142
==========================================
+ Hits 29951 30093 +142
Misses 7314 7314 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
308a204 to
c2e2874
Compare
This comment was marked as resolved.
This comment was marked as resolved.
6e9d6fe to
f60e614
Compare
8235b27 to
30911e5
Compare
Add empty __all__ to exp_to_source/main.py script
…, guider_cds, lastframe, and linearity
…place, reset, and rscd
…tometry, wavecorr, wfs_combine, and white_light
8c222a8 to
23d9688
Compare
melanieclarke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks fine to me. Setting up __all__ should do no harm, and we can always add or remove to what's included here as we go. I checked, and it looks like the changes here do not impact documentation for the places we've included automodapi.
Thanks again for tidying up!
Closes #9385
Unless users are doing star imports on the affected modules, which they should not in the first place, there is no change that needs to be documented in change log.
grep "__all__" -Lr . | grep "\.py" | grep -v "test"would tell you most of them, minus a couple of obvious ones you can ignore.Partially assisted by generate_all.
TODO
__all__to remaining modules.grepagain to make sure I didn't miss anything.Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)docs/pageokify_regteststo update the truth files