Skip to content

Conversation

@melanieclarke
Copy link
Collaborator

@melanieclarke melanieclarke commented Jun 24, 2025

Closes #9578

Catch bad values in the computed weight matrix for method='fft' in clean_flicker_noise.

Without this fix, the step occasionally sets entire images to NaN. Test data is jw04645006001_03101_00004_nrs1_rate.fits.

Tasks

  • If you have a specific reviewer in mind, tag them.
  • add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@melanieclarke melanieclarke added this to the Build 12.1 milestone Jun 24, 2025
@melanieclarke
Copy link
Collaborator Author

melanieclarke commented Jun 24, 2025

@codecov
Copy link

codecov bot commented Jun 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.22%. Comparing base (bebd3be) to head (ba9b54c).
⚠️ Report is 291 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9585      +/-   ##
==========================================
- Coverage   81.25%   81.22%   -0.04%     
==========================================
  Files         366      368       +2     
  Lines       37427    37501      +74     
==========================================
+ Hits        30413    30459      +46     
- Misses       7014     7042      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@melanieclarke melanieclarke force-pushed the fix_fft_weights branch 2 times, most recently from fefc67e to 327bb51 Compare June 26, 2025 13:58
@melanieclarke melanieclarke marked this pull request as ready for review July 7, 2025 14:11
@melanieclarke melanieclarke requested review from a team as code owners July 7, 2025 14:11
@melanieclarke melanieclarke requested a review from tapastro July 7, 2025 21:02
Copy link
Contributor

@tapastro tapastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tapastro tapastro enabled auto-merge (squash) July 28, 2025 16:29
@tapastro tapastro merged commit da67809 into spacetelescope:main Jul 28, 2025
28 checks passed
@melanieclarke melanieclarke deleted the fix_fft_weights branch July 28, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stage 2 extract1d failing (all NaN after nsclean)

2 participants