Skip to content

Conversation

@zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Jun 9, 2025

@codecov
Copy link

codecov bot commented Jun 9, 2025

Codecov Report

❌ Patch coverage is 41.17647% with 10 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release/1.18.x@1b78507). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...t/associations/generator/generate_per_candidate.py 41.17% 10 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             release/1.18.x    #9529   +/-   ##
=================================================
  Coverage                  ?   74.61%           
=================================================
  Files                     ?      369           
  Lines                     ?    37154           
  Branches                  ?        0           
=================================================
  Hits                      ?    27722           
  Misses                    ?     9432           
  Partials                  ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@tapastro tapastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This backport accumulated some extraneous changes - the regtest file diff is mostly a refactor introduced by https://github.com/spacetelescope/jwst/pull/9470/files

I think it'd be best to revert changes made in that file, though I'm sure the STASIS tests will be difficult. I can make a PR/commit to your backport PR branch with suggested changes.

… prevent undesirable associations in DMS operations
@zacharyburnett zacharyburnett force-pushed the auto-backport-of-pr-9501-on-release/1.18.x branch from e93d6fc to 0ce0082 Compare June 9, 2025 19:19
@tapastro
Copy link
Contributor

tapastro commented Jun 9, 2025

My recollection of the expected diffs with 1.18.0 artifacts led me to add a single asn to the truth output for the jw04225{...}DMS_pool test - hopefully when run against the 1.18.0 artifacts this will come back clean 🤞

@zacharyburnett
Copy link
Collaborator Author

@zacharyburnett
Copy link
Collaborator Author

the only test NEWLY failing (not also failing on main) is jwst.regtest.test_nircam_image::test_nircam_image_detector1_with_clean_flicker_noise[flicker_noise]:
https://github.com/spacetelescope/RegressionTests/actions/runs/15542486090/attempts/2#summary-43757128635

@zacharyburnett zacharyburnett merged commit 699bda8 into spacetelescope:release/1.18.x Jun 10, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants