Skip to content

Conversation

@nden
Copy link
Collaborator

@nden nden commented May 13, 2025

Resolves JP-nnnn

This PR addresses style issues in the dark_current step.

Tasks

  • If you have a specific reviewer in mind, tag them.
  • add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@nden nden requested a review from a team as a code owner May 13, 2025 21:30
@codecov
Copy link

codecov bot commented May 13, 2025

Codecov Report

❌ Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.86%. Comparing base (9c837cd) to head (70b454f).
⚠️ Report is 649 commits behind head on main.

Files with missing lines Patch % Lines
jwst/dark_current/dark_current_step.py 61.53% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9457   +/-   ##
=======================================
  Coverage   77.86%   77.86%           
=======================================
  Files         362      362           
  Lines       36335    36335           
=======================================
  Hits        28294    28294           
  Misses       8041     8041           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tapastro
Copy link
Contributor

Removing the dark_current module from the pre-commit and ruff config files should be part of this update - and will let you know if you've missed anything.

@nden nden requested a review from a team as a code owner May 14, 2025 16:01
Copy link
Contributor

@tapastro tapastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pllim pllim added this to the Build 12.0 milestone May 14, 2025
Copy link
Collaborator

@emolter emolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but would you please run the regression tests just in case? (we have been doing so for all the other style changes)

@nden
Copy link
Collaborator Author

nden commented May 14, 2025

@emolter emolter self-requested a review May 14, 2025 17:39
@nden nden merged commit f7f4473 into spacetelescope:main May 14, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants