-
Notifications
You must be signed in to change notification settings - Fork 181
Fix style in dark_current #9457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9457 +/- ##
=======================================
Coverage 77.86% 77.86%
=======================================
Files 362 362
Lines 36335 36335
=======================================
Hits 28294 28294
Misses 8041 8041 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Removing the dark_current module from the pre-commit and ruff config files should be part of this update - and will let you know if you've missed anything. |
tapastro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
emolter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but would you please run the regression tests just in case? (we have been doing so for all the other style changes)
Resolves JP-nnnn
This PR addresses style issues in the dark_current step.
Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)docs/pageokify_regteststo update the truth files