Skip to content

Conversation

@pllim
Copy link
Collaborator

@pllim pllim commented Apr 8, 2025

Resolves JP-3923

xref #1397

close #9325

This PR localizes test warnings as much as possible. This is basically #9325 but without the blind RuntimeWarning ignores that raised concerns. In place of those ignores are now # FIXME comment for the future. Global test warning filters now remain untouched to avoid failing regtest that is peppered with warnings. The -W error in tox.ini theoretically should be enough to turn all unhandled warnings in regular CI using tox into exceptions. 🤞

Tasks

@github-actions github-actions bot added regression_testing wfss_contam automation Continuous Integration (CI) and testing automation tools master_background labels Apr 8, 2025
@codecov
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.39%. Comparing base (1c93ca5) to head (d32c679).
Report is 673 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9381   +/-   ##
=======================================
  Coverage   75.39%   75.39%           
=======================================
  Files         368      368           
  Lines       36842    36842           
=======================================
  Hits        27777    27777           
  Misses       9065     9065           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pllim pllim marked this pull request as ready for review April 9, 2025 00:49
@pllim pllim requested review from a team as code owners April 9, 2025 00:49
@pllim
Copy link
Collaborator Author

pllim commented Apr 9, 2025

With this PR, you will notice that there are no warnings in the CI test logs, but still warnings in RT (https://github.com/spacetelescope/RegressionTests/actions/runs/14344612421/job/40211860319). Both passed.

@pllim pllim requested a review from melanieclarke April 9, 2025 00:50
@pllim pllim mentioned this pull request Apr 9, 2025
10 tasks
@pllim pllim force-pushed the exorcise-test-warns-dial-it-down-from-11 branch from 1555563 to 4332463 Compare April 9, 2025 20:46
@pllim
Copy link
Collaborator Author

pllim commented Apr 9, 2025

Copy link
Collaborator

@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good now, except for the one CI change that I think we should move to a separate PR. Remind us if we don't come back around to properly cleaning up the warnings in the regression tests.

I'll leave this open for today in case anyone else wants to review.

pllim added 5 commits April 10, 2025 12:07
Use astropy utils functions to handle test data.
Test data dirs no longer importable as subpackage
as they are properly packaged as data.
Move one data file to data dir.
but put a FIXME note for future.

Some minor clean-ups
and save it for different PR
@pllim pllim force-pushed the exorcise-test-warns-dial-it-down-from-11 branch from 4332463 to 9218a32 Compare April 10, 2025 16:08
@melanieclarke melanieclarke enabled auto-merge April 11, 2025 12:57
@melanieclarke melanieclarke merged commit 461c9ba into spacetelescope:main Apr 11, 2025
19 checks passed
@pllim pllim deleted the exorcise-test-warns-dial-it-down-from-11 branch April 11, 2025 13:38
@pllim
Copy link
Collaborator Author

pllim commented Apr 11, 2025

Thanks for your patience!

@pllim pllim mentioned this pull request Apr 29, 2025
10 tasks
@pllim pllim mentioned this pull request May 29, 2025
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment