-
Notifications
You must be signed in to change notification settings - Fork 180
JP-3923: Localize test warnings (try 2), fix test data packaging, misc test clean-ups #9381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3923: Localize test warnings (try 2), fix test data packaging, misc test clean-ups #9381
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9381 +/- ##
=======================================
Coverage 75.39% 75.39%
=======================================
Files 368 368
Lines 36842 36842
=======================================
Hits 27777 27777
Misses 9065 9065 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
With this PR, you will notice that there are no warnings in the CI test logs, but still warnings in RT (https://github.com/spacetelescope/RegressionTests/actions/runs/14344612421/job/40211860319). Both passed. |
1555563 to
4332463
Compare
|
https://github.com/spacetelescope/RegressionTests/actions/runs/14366715093/attempts/1#summary-40281436373 passed except 1 known failure in devdeps |
melanieclarke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good now, except for the one CI change that I think we should move to a separate PR. Remind us if we don't come back around to properly cleaning up the warnings in the regression tests.
I'll leave this open for today in case anyone else wants to review.
Use astropy utils functions to handle test data. Test data dirs no longer importable as subpackage as they are properly packaged as data. Move one data file to data dir.
but put a FIXME note for future. Some minor clean-ups
but not CI
and save it for different PR
4332463 to
9218a32
Compare
|
Thanks for your patience! |
Resolves JP-3923
xref #1397
close #9325
This PR localizes test warnings as much as possible. This is basically #9325 but without the blind
RuntimeWarningignores that raised concerns. In place of those ignores are now# FIXMEcomment for the future. Global test warning filters now remain untouched to avoid failing regtest that is peppered with warnings. The-W errorintox.initheoretically should be enough to turn all unhandled warnings in regular CI using tox into exceptions. 🤞Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)docs/pageokify_regteststo update the truth files