Skip to content

Conversation

@jemorrison
Copy link
Collaborator

@jemorrison jemorrison commented Apr 7, 2025

Helps to resolves JP-3857

This PR updates the linearity step with the new code style for doc strings

Tasks

@codecov
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.39%. Comparing base (d32c679) to head (ff5d398).
Report is 673 commits behind head on main.

Files with missing lines Patch % Lines
jwst/linearity/linearity_step.py 62.50% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9368   +/-   ##
=======================================
  Coverage   75.39%   75.39%           
=======================================
  Files         368      368           
  Lines       36842    36842           
=======================================
  Hits        27777    27777           
  Misses       9065     9065           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jemorrison jemorrison force-pushed the JP-3857_linearity_code_style branch from c4c31f1 to c8dff6b Compare April 10, 2025 19:32
@jemorrison
Copy link
Collaborator Author

@melanieclarke Ready for review. Regression tests have passed.

Copy link
Collaborator

@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! It needs one small typo correction, then we should be able to get this in.

@jemorrison jemorrison force-pushed the JP-3857_linearity_code_style branch from 2b5bc4c to 8639191 Compare April 15, 2025 16:47
Copy link
Collaborator

@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@melanieclarke melanieclarke enabled auto-merge April 15, 2025 18:11
@melanieclarke melanieclarke merged commit 0f28e4d into spacetelescope:main Apr 15, 2025
19 checks passed
@jemorrison jemorrison deleted the JP-3857_linearity_code_style branch September 30, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants