Skip to content

Conversation

@stscirij
Copy link
Contributor

@stscirij stscirij commented Apr 4, 2025

Resolves JP-3912

This PR modifies some tests for steps that have skip=True by default. The new tests verify that when a step is called standalone, step.skip is True. Also, each step is run in a pipeline and the meta.cal_step.step is checked for the
appropriate value "SKIPPED" or "COMPLETE", depending on whether skip is True or False respectively.

Tasks

  • If you have a specific reviewer in mind, tag them.
  • add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@stscirij stscirij requested a review from a team as a code owner April 4, 2025 15:35
@codecov
Copy link

codecov bot commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.40%. Comparing base (2789ad2) to head (8e905e3).
Report is 681 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9364      +/-   ##
==========================================
+ Coverage   75.18%   75.40%   +0.21%     
==========================================
  Files         368      368              
  Lines       36837    36837              
==========================================
+ Hits        27696    27777      +81     
+ Misses       9141     9060      -81     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@melanieclarke melanieclarke added this to the Build 12.0 milestone Apr 7, 2025
Copy link
Collaborator

@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Please push up the one small change Tyler suggested, and link to a regression test run, then we should be able to get this in.

@stscirij stscirij force-pushed the jp-3912_standalone_noskip branch from 80b7321 to c95c920 Compare April 7, 2025 19:01
@stscirij
Copy link
Contributor Author

stscirij commented Apr 7, 2025

Copy link
Collaborator

@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fixes.

@melanieclarke melanieclarke enabled auto-merge April 8, 2025 13:23
@melanieclarke melanieclarke merged commit e3bbcd0 into spacetelescope:main Apr 8, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants