-
Notifications
You must be signed in to change notification settings - Fork 181
JP-3912: Modify some tests for steps that are skipped by default #9364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3912: Modify some tests for steps that are skipped by default #9364
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9364 +/- ##
==========================================
+ Coverage 75.18% 75.40% +0.21%
==========================================
Files 368 368
Lines 36837 36837
==========================================
+ Hits 27696 27777 +81
+ Misses 9141 9060 -81 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
melanieclarke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Please push up the one small change Tyler suggested, and link to a regression test run, then we should be able to get this in.
80b7321 to
c95c920
Compare
|
Full set of regression tests here: https://github.com/spacetelescope/RegressionTests/actions/runs/14318477612 |
melanieclarke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the fixes.
Resolves JP-3912
This PR modifies some tests for steps that have skip=True by default. The new tests verify that when a step is called standalone, step.skip is True. Also, each step is run in a pipeline and the meta.cal_step.step is checked for the
appropriate value "SKIPPED" or "COMPLETE", depending on whether skip is True or False respectively.
Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)docs/pageokify_regteststo update the truth files