-
Notifications
You must be signed in to change notification settings - Fork 181
Fix inadvertent removal of __all__ #9338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
melanieclarke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks Robert! No need to run regression tests for this.
pllim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small comment. Thanks!
changes/9338.ramp_fitting.rst
Outdated
| @@ -0,0 +1 @@ | |||
| Restore __all__ definition that was removed in an earlier PR | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If user won't notice anything, not sure if this actually needs a change log. I'll leave that up to you. If you want to keep it, here is a suggestion.
| Restore __all__ definition that was removed in an earlier PR | |
| Restore ``__all__`` definition that was removed in an earlier PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I kept it with your suggestion!
|
@meeseeksdev backport to release/1.18.x |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9338 +/- ##
=======================================
Coverage 74.69% 74.69%
=======================================
Files 369 368 -1
Lines 37117 37107 -10
=======================================
- Hits 27723 27718 -5
+ Misses 9394 9389 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…f __all__) (#9339) Co-authored-by: Robert Jedrzejewski <[email protected]> Co-authored-by: Tyler Pauly <[email protected]>
|
Just for accurate bookkeeping, does that mean milestone for this PR and its backport is really 11.3, not 12.0? |
Yes, it should be 11.3. I'll update it. |
No JP ticket or issue for this fix
This PR puts back the _all statement that got inadvertently removed in a previous PR
Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)docs/pageokify_regteststo update the truth files