limit regression test result search to jwst files #8026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
regression_testing
automation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know!. |
hbushouse
approved these changes
Oct 24, 2023
braingram
force-pushed
the
artifact_upload
branch
from
40f71ab to
fcfdb3e
Compare
Collaborator
|
Is this ready to merge? |
Collaborator
Author
|
Thanks for taking a look and following up. This is ready to merge. Should we wait to rebase after #8032 is merged? |
Collaborator
Yes, let's wait for that other PR to get merged, then rebase and merge this one. |
braingram
force-pushed
the
artifact_upload
branch
from
fcfdb3e to
e771b7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the jenkins configuration files to limit what files are considered for uploading during the
Upload artifactsstep. The changes here are the same as those applied in this romancal PR:spacetelescope/romancal#950
If/when jwst adds
astroquery(orwebbpsfwhich depends onastroquery) the jenkins runs will fail on theUpload artifactsstep due to searching files beyond those that are generated when attempting to upload test results to artifactory. This search will fail due to finding the mission_results.json file in the astroquery package.This PR limits the files searched to those generated during the pytest run in the jenkins workflow.
Regression tests passed with no errors: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1015/
Checklist for maintainers
CHANGES.rstwithin the relevant release sectionHow to run regression tests on a PR