JP-3424 Extend engineering coverage time for guiding modes #7966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stscieisenhamer
added
bug
sdp
tapastro
approved these changes
Sep 21, 2023
Collaborator
Author
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
hbushouse
approved these changes
Sep 22, 2023
Collaborator
hbushouse
left a comment
hbushouse
left a comment
There was a problem hiding this comment.
Code looks find, but the tests are failing.
This reverts commit fa81e50.
stscieisenhamer
force-pushed
the
stpgsengfail
branch
from
5c9a333 to
43b12d0
Compare
Collaborator
Author
|
Yet Another Regression Run. This one is limited to the pointing and engineering tests, but now they do all pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JP-3424
Closes #7963
This PR addresses an issue discovered during Build 10.0 integration with WCS determination in set_telescope_pointing. A new algorithm for the various guider products has been implemented, which require more engineering coverage than science exposures. Turns out that not enough leeway being given. This PR extends the coverage time to use when retrieving engineering data.
Checklist for maintainers
CHANGES.rstwithin the relevant release sectionupdated relevant documentationHow to run regression tests on a PR