-
Notifications
You must be signed in to change notification settings - Fork 181
Fix spec class attribute for PersistenceStep and RefPixStep #7803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hbushouse
merged 5 commits into
spacetelescope:master
from
jdavies-st:jump-fix-spec-comments
Aug 16, 2023
Merged
Fix spec class attribute for PersistenceStep and RefPixStep #7803
hbushouse
merged 5 commits into
spacetelescope:master
from
jdavies-st:jump-fix-spec-comments
Aug 16, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #7803 +/- ##
=======================================
Coverage 76.54% 76.54%
=======================================
Files 456 456
Lines 36947 36947
=======================================
Hits 28282 28282
Misses 8665 8665
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
hbushouse
reviewed
Aug 10, 2023
hbushouse
reviewed
Aug 10, 2023
513d4c4 to
067dfb0
Compare
067dfb0 to
e0b35a6
Compare
hbushouse
approved these changes
Aug 16, 2023
Collaborator
hbushouse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mairanteodoro
pushed a commit
to mairanteodoro/jwst
that referenced
this pull request
Sep 20, 2023
…escope#7803) Co-authored-by: Nadia Dencheva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the comments inJumpStep.specwhich were missing#before the comment.PersistenceStep.speccomments were also not formatted correctly and too long.RefPixStep.speccomments were completely missing. Pulled summaries of these from the docs.Now all steps produce proper output when one does:
Also a small change in
assign_wcspicked up by the style checkerChecklist for maintainers
CHANGES.rstwithin the relevant release sectionHow to run regression tests on a PR