Skip to content

Conversation

@jdavies-st
Copy link
Collaborator

@jdavies-st jdavies-st commented Aug 9, 2023

This PR fixes the comments in JumpStep.spec which were missing # before the comment.

PersistenceStep.spec comments were also not formatted correctly and too long.

RefPixStep.spec comments were completely missing. Pulled summaries of these from the docs.

Now all steps produce proper output when one does:

$ strun step_alias --help

Also a small change in assign_wcs picked up by the style checker

check-style: commands[0]> ruff .
jwst/assign_wcs/nirspec.py:404:8: E721 Do not compare types, use `isinstance()`
jwst/assign_wcs/nirspec.py:1828:8: E721 Do not compare types, use `isinstance()`

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c86ff0e) 76.54% compared to head (2c8b50c) 76.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7803   +/-   ##
=======================================
  Coverage   76.54%   76.54%           
=======================================
  Files         456      456           
  Lines       36947    36947           
=======================================
  Hits        28282    28282           
  Misses       8665     8665           
Flag Coverage Δ *Carryforward flag
nightly 77.39% <ø> (ø) Carriedforward from 6707e76

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
jwst/persistence/persistence_step.py 67.79% <ø> (ø)
jwst/refpix/refpix_step.py 73.17% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hbushouse hbushouse added this to the Build 10.0 milestone Aug 10, 2023
@jdavies-st jdavies-st force-pushed the jump-fix-spec-comments branch from 067dfb0 to e0b35a6 Compare August 11, 2023 07:42
@github-actions github-actions bot removed the jump label Aug 12, 2023
@jdavies-st jdavies-st changed the title Fix spec class attribute for JumpStep, PersistenceStep and RefPixStep Fix spec class attribute for PersistenceStep and RefPixStep Aug 12, 2023
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hbushouse hbushouse merged commit 63e6ec8 into spacetelescope:master Aug 16, 2023
@jdavies-st jdavies-st deleted the jump-fix-spec-comments branch August 16, 2023 14:16
mairanteodoro pushed a commit to mairanteodoro/jwst that referenced this pull request Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants