JP-3237 Compute correct exposure times for combined images #7793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #7793 +/- ##
=======================================
Coverage 76.54% 76.54%
=======================================
Files 456 456
Lines 36941 36947 +6
=======================================
+ Hits 28276 28282 +6
Misses 8665 8665
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
penaguerrero
changed the title
penaguerrero
force-pushed
the
resample_update_exp_times
branch
from
0181d5c to
09f9455
Compare
hbushouse
suggested changes
Aug 8, 2023
penaguerrero
force-pushed
the
resample_update_exp_times
branch
2 times, most recently
from
01f34b7 to
8df12b5
Compare
hbushouse
suggested changes
Aug 10, 2023
penaguerrero
force-pushed
the
resample_update_exp_times
branch
from
d0c9dc7 to
db6adfb
Compare
Collaborator
|
Regression test started at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/859 |
Collaborator
|
Regtest results show only the expected keyword value differences. |
mairanteodoro
pushed a commit
to mairanteodoro/jwst
that referenced
this pull request
Sep 20, 2023
…scope#7793) Co-authored-by: Howard Bushouse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JP-3237
Closes #7737
This PR sets the exposure time related keywords EFFEXPTM, XPOSURE, DURATION, and TELAPSE to their appropriate combined times in the resample/resample_spec output products, reflecting the proper sum of times across all input exposures (but not across multiple detectors).
Checklist for maintainers
CHANGES.rstwithin the relevant release sectionHow to run regression tests on a PR